I took the Rprogs R code and created a simple R library named "LC". If you want to call the "dcdft " function all you have to do is (in R):
Documention is here (readme.md):
Demo code and data:
It's great that you're thinking in terms of making Grant's code more accessible and that you have provided attribution to Grant as author in the GitHub README file, but I have a couple of questions:
- Have you asked Grant whether he is OK for you to make his code available on GitHub? He may very well be, but it's worth checking I think.
- I don't see a licence file. Again, Grant may not care, especially given that the zip file is available on the AAVSO web site, but may be worth asking.
I'm not saying any of this to be negative. The intention is awesome. Just to take things slowly.
Thanks for you suggestions.
Do you have Grants contact information, it's not listed any where code ? At the bottom of the ReadMe.txt are the initals Q.E.D.?
The reason there is no licience is because it's not my code...
I realised I never replied to this! Apologies David.
It may be necessary to ask HQ for advice on how best to contact Grant.
I agree that getting Grant's code on GitHub is worthwhile since further improvements and additions can more easily be community based. I think it would be best if was here though: https://github.com/AAVSO
I'll ask HQ about this in email.
I contacted Grant Foster and he said that he is happy to share his R scripts with the world, so I followed David's suggestion and created a repository for the on the AAVSO's GitHub account: https://github.com/AAVSO/Rcodes
Please feel free to create a branch and add your updates.